refactor(dashboard,cli): thread mutation context through routes, tools and CLI (5/5) - #3433
refactor(dashboard,cli): thread mutation context through routes, tools and CLI (5/5)#3433gsxdsm wants to merge 5 commits into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| Filename | Overview |
|---|---|
| packages/cli/src/extension.ts | Threads resolved mutation context through extension tools and preserves fail-closed handling for unresolved or ambiguous callers. |
| packages/dashboard/src/routes.ts | Propagates mutation context through dashboard route mutations as part of the required store contract. |
| packages/dashboard/app/utils/appLifecycle.ts | Carries the per-process desktop API token during navigation to the loopback local runtime. |
| packages/desktop/src/local-runtime.ts | Supplies the authenticated loopback runtime URL and ephemeral desktop API token to the renderer. |
| .changeset/u18-stage-d-mutation-context-dashboard-cli.md | Provides the required patch changeset and release summary for the published CLI and extension behavior. |
Reviews (13): Last reviewed commit: "Merge remote-tracking branch 'origin/ide..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
404e3a8 to
be439e7
Compare
8a1bd17 to
bd706d5
Compare
be439e7 to
a167214
Compare
bd706d5 to
5d25a3e
Compare
a167214 to
3129138
Compare
5d25a3e to
35c2777
Compare
|
@coderabbitai review |
|
|
Review feedback addressed in Fixed — the findings were correct:
The matcher finding deserves its own note. It was exactly right, and the blast radius was real: tightening exposed 15 genuinely unattributed writes across 11 suites that the loose matcher had been passing as attributed. Those now assert Not applied, with reasons:
Verification. Measured against a baseline of the same tree with these edits reverted, so pre-existing failures aren't attributed to this change: 77 failed files / 258 failed tests before → 77 / 263 after, with no file this change touches newly failing. |
3129138 to
ccec4fb
Compare
35c2777 to
2b5f59a
Compare
ccec4fb to
626dc8b
Compare
2b5f59a to
bcbf289
Compare
|
Stack rebased so every chunk carries its own review fixes; the stack tip is byte-identical to the full branch ( One further real finding fixed ( Re-posted findings that are already fixed in the current tree (the bot re-reviewed against pre-fix line numbers):
Still declined: the FNXC-trace requests across the executor files. All ten already carry FNXC comments and the changed blocks are mechanical propagation of a conversion documented once at its seam; ten near-identical "attribution threaded here" notes are noise, not traceability. CI: #3428 7/7 green, #3429 6/6, #3431–#3433 all green. The only red mark is the Greptile check itself, which reports its own open findings rather than a build result. |
626dc8b to
6b1eba8
Compare
bcbf289 to
4638509
Compare
6b1eba8 to
2ed6e5f
Compare
4638509 to
3127764
Compare
2ed6e5f to
ac4c482
Compare
3127764 to
8072e2a
Compare
ac4c482 to
ab5d8ca
Compare
…uired (5/5) Fusion-Task-Id: FN-8821 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
8072e2a to
d66c671
Compare
…entity/5-dashboard-cli # Conflicts: # packages/cli/src/commands/task.ts # packages/cli/src/extension.ts # packages/dashboard/src/__tests__/routes-tasks.test.ts # packages/dashboard/src/routes/register-task-workflow-routes.ts # packages/dashboard/src/server.ts
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| const location = stubLocation("file:///C:/app/index.html"); | ||
| stubShell({ | ||
| ...localReadyState, | ||
| localRuntime: { ...localReadyState.localRuntime, authToken: "fn_0123456789abcdef0123456789abcdef" }, |
| state: "running", | ||
| baseUrl: "http://127.0.0.1:50123", | ||
| port: 50123, | ||
| authToken: "fn_0123456789abcdef0123456789abcdef", |
| desktopMode: "local", | ||
| activeProfileId: null, | ||
| profiles: [], | ||
| localRuntime: { state: "running", port: 50123, authToken: "fn_0123456789abcdef0123456789abcdef" }, |
| const location = stubLocation("file:///C:/app/index.html"); | ||
| stubShell({ | ||
| ...localReadyState, | ||
| localRuntime: { ...localReadyState.localRuntime, authToken: "fn_0123456789abcdef0123456789abcdef" }, |
| state: "running", | ||
| baseUrl: "http://127.0.0.1:50123", | ||
| port: 50123, | ||
| authToken: "fn_0123456789abcdef0123456789abcdef", |
| desktopMode: "local", | ||
| activeProfileId: null, | ||
| profiles: [], | ||
| localRuntime: { state: "running", port: 50123, authToken: "fn_0123456789abcdef0123456789abcdef" }, |
ThreatCrush Security Scan4530 finding(s) HIGH/CRITICAL: 43 | MEDIUM: 3990 | LOW: 497
…and 4480 more. Full results in the Security tab. Snippets are redacted; ThreatCrush never prints matched credential material. |
# Conflicts: # packages/cli/src/commands/task-lifecycle.ts # packages/cli/src/commands/task.ts # packages/dashboard/src/__tests__/task-revert-route.test.ts # packages/dashboard/src/routes/register-task-workflow-routes.ts
2 participants
Stack 5/5 — 89 files. Base:
identity/4-engine-tests.Dashboard routes, CLI commands, pi extension, desktop. Stack tip is byte-identical to the reviewed full branch.
🤖 Generated with Claude Code