Clear the cached currency keys in Currency.reset! - #1228
Open
lenamonj wants to merge 1 commit into
Open
Conversation
Author
|
The red jruby-10.0 job is the pre-existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currency.reset!reloads the table and clears the instance and iso_numeric caches, but not the memoized key set thatCurrency.newgates on. Afterregister, a lookup, thenreset!,Currency.newstill admitted the removed id and raisedNoMethodErrorfrominitialize_data!instead ofUnknownCurrency, whichfinddoes not rescue.reset!now clears the key set as well. The new spec fails on main and passes with the change; rspec and rubocop are clean. CHANGELOG and AUTHORS updated.