Fix Batch Norm - #423
Open
andrewdalpino wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes BatchNorm to normalize using the batch size (matrix n()) rather than the feature width (matrix m()), addressing incorrect statistics/gradients that were previously hidden by square (m == n) test matrices.
Changes:
- Update forward-pass variance calculation to use a mean-of-squared-deviations formulation aligned to the batch dimension.
- Fix backward gradient scaling to use
dOut->n()(batch size) instead ofdOut->m()(width/features). - Add a regression test using a non-square input matrix to ensure the bug can’t be masked.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/NeuralNet/Layers/BatchNormTest.php | Adds a non-square (3×4) regression test to validate batch-dimension normalization in forward/backward/infer. |
| src/NeuralNet/Layers/BatchNorm.php | Corrects variance computation and gradient scaling to normalize over batch size (n()). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
apphp
approved these changes
Aug 16, 2026
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BatchNorm normalizes by width, not batch size — src/NeuralNet/Layers/BatchNorm.php:184, 290-293. Matrix::variance() divides by row count (features); backward uses dOut->m() where batch size n() belongs. Masked by square test matrices.