[Fix] Auto denials no longer point to a transcript control that doesn't exist - #3332
Merged
Merged
Conversation
Contributor
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Internal follow-up to #3116; no separate issue is linked.
Why this PR exists
What changed
When Auto denies a tool call because the session owner is away, the agent used to be told "The session owner can allow this tool from its call in the transcript." No such control exists: an auto-rejected call leaves nothing in the transcript to allow. The agent repeated this to users, so they were sent to look for a button that isn't there.
The agent is now told to continue without the call, tell the owner what was skipped, and that they can ask for it again while they are in the session and approve it when asked. Sessions and tasks share one message,
describeIntegrationToolAutoAbsentDenialin@roomote/types, so the two paths can't drift apart again.How it was tested
pnpm lint, and formatting pass.Checklist
[Fix],[Feat],[Improve],[Refactor],[Docs], or[Chore]followed by a user-facing descriptionpnpm lintandpnpm check-typespass locallypnpm changeset(not needed: Auto is a nightly-only experiment)Combined local smoke (2026-09-30)
All six Auto/approval PRs (#3332, #3334, #3335, #3337, #3338, #3339) were merged together locally and run on a local stack. It used a real web session with Auto on, Jev through OpenRouter, and a local MCP server whose tools only log (
list_files,delete_file,pay_invoice). The PRs merge cleanly into develop in any order, except #3332 and #3337: both add an export next to each other inpackages/types, and whichever lands second needs a trivial rebase. The combined build passes uncachedpnpm check-types,pnpm lint, and the approval suites (cloud-agents 131, sdk 23, worker 13, db 32).delete_fileauto-approved (authorization 0.97, highest risk level). Alist_fileswith no arguments now shows a card instead of failing the insert.list_fileswas assessed by Auto (auto-approved row).Not covered live: chat surfaces (Slack, Telegram, Discord) and the task (sandbox) path, because there's no local worker. Both are covered by unit tests.