Skip to content

[Refactor] Consolidate deployment experiment runtime state - #3223

Merged
mrubens merged 2 commits into
developfrom
refactor/consolidate-deployment-experiments-3rt1cndz40lnr1
Sep 25, 2026
Merged

mrubens merged 2 commits into
developfrom
refactor/consolidate-deployment-experiments-3rt1cndz40lnr1

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Created by Roomote. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Consolidated deployment experiment audience, metadata-key, and member-readable runtime eligibility into one typed feature-flag descriptor.
  • Replaced the feature-specific nightly runtime procedures with one parameterized runtime read and one shared client hook for Dizzy and Auto tool approvals.
  • Replaced hard-coded runtime invalidation branches with descriptor-driven invalidation while retaining a single query for the selected customer-preview or internal-nightly audience.

Why this change was made

PR #3190 and PR #3207 left audience selection, runtime eligibility, and cache invalidation split across separate contracts. The shared descriptor makes adding another nightly experiment a typed classification instead of another feature-specific query or invalidation branch.

Impact

Admin-only management reads and writes remain separated between customer-preview and internal-nightly audiences. Member-readable runtime reads still require the server-provided nightly deployment opt-in, and server-side experiment checks still enforce R_NIGHTLY_EXPERIMENTS_ENABLED; nightly settings without a runtime surface remain unavailable to members. Focused feature-flags, database, web client, and web server tests passed, as did full lint, typecheck, and pre-push checks. The full web test run passed all client tests but retained eight existing environment-sensitive dev-login failures; browser proof is not applicable to this non-visual contract refactor.

@roomote-community

roomote-community Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 2f1c929

@roomote-roomote
roomote-roomote Bot marked this pull request as ready for review September 25, 2026 07:49
@mrubens
mrubens merged commit 2eb4434 into develop Sep 25, 2026
18 checks passed
@mrubens
mrubens deleted the refactor/consolidate-deployment-experiments-3rt1cndz40lnr1 branch September 25, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants