[Refactor] Consolidate deployment experiment runtime state - #3223
Merged
mrubens merged 2 commits intoSep 25, 2026
Merged
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 25, 2026 07:49
…te-deployment-experiments-3rt1cndz40lnr1
mrubens
deleted the
refactor/consolidate-deployment-experiments-3rt1cndz40lnr1
branch
September 25, 2026 10:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
PR #3190 and PR #3207 left audience selection, runtime eligibility, and cache invalidation split across separate contracts. The shared descriptor makes adding another nightly experiment a typed classification instead of another feature-specific query or invalidation branch.
Impact
Admin-only management reads and writes remain separated between customer-preview and internal-nightly audiences. Member-readable runtime reads still require the server-provided nightly deployment opt-in, and server-side experiment checks still enforce
R_NIGHTLY_EXPERIMENTS_ENABLED; nightly settings without a runtime surface remain unavailable to members. Focused feature-flags, database, web client, and web server tests passed, as did full lint, typecheck, and pre-push checks. The full web test run passed all client tests but retained eight existing environment-sensitive dev-login failures; browser proof is not applicable to this non-visual contract refactor.