Repository navigation
[Improve] Restore the Auto tool approvals experimental setting - #3211
Closed
daniel-lxs wants to merge 1 commit into
Closed
daniel-lxs wants to merge 1 commit into
daniel-lxs wants to merge 1 commit into
Conversation
Contributor
Member
Author
|
Closing: the Auto tool approvals switch now lives under Nightly Experiments (#3207), so restoring the old experimental setting is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Restores the Auto tool approvals switch in Settings → Experimental, which #3180 hid. The component and its test come back as they were, and the control is registered again in the experiment settings list (
experiment-settings-controls.tsx) under the experiment's existingcustomer-previewaudience, so it appears on the Experimental page and not on the internal Nightly page.Why this change was made
The switch was hidden because Auto was asking for approval on harmless reads. #3185 fixed those decisions (request context, judgment criteria, read content, and a credential scan), so the switch can be offered again.
Impact
Admins can turn the Auto tool approvals experiment on or off again from Settings → Experimental. The experiment stays off unless an admin turns it on; nothing about the experiment's default or gating changes.
How it was tested
@roomote/webtype check, oxfmt, and oxlint on changed files passed.