Skip to content

[Improve] Restore the Auto tool approvals experimental setting - #3211

Closed
daniel-lxs wants to merge 1 commit into
developfrom
feat/restore-auto-approvals-setting
Closed

daniel-lxs wants to merge 1 commit into
developfrom
feat/restore-auto-approvals-setting

Conversation

@daniel-lxs

Copy link
Copy Markdown
Member

What changed

Restores the Auto tool approvals switch in Settings → Experimental, which #3180 hid. The component and its test come back as they were, and the control is registered again in the experiment settings list (experiment-settings-controls.tsx) under the experiment's existing customer-preview audience, so it appears on the Experimental page and not on the internal Nightly page.

Why this change was made

The switch was hidden because Auto was asking for approval on harmless reads. #3185 fixed those decisions (request context, judgment criteria, read content, and a credential scan), so the switch can be offered again.

Impact

Admins can turn the Auto tool approvals experiment on or off again from Settings → Experimental. The experiment stays off unless an admin turns it on; nothing about the experiment's default or gating changes.

How it was tested

  • Settings page and Auto-related web tests: 10 files, 23 tests passed.
  • @roomote/web type check, oxfmt, and oxlint on changed files passed.

Bring back the Settings > Experimental switch for Auto tool approvals that
#3180 hid, now that #3185 fixed the Auto decisions that asked about harmless
reads. The control is registered in the experiment settings list again under
its customer-preview audience.
@roomote-community

roomote-community Bot commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

No code issues found. See task

Reviewed 130035b

@daniel-lxs

Copy link
Copy Markdown
Member Author

Closing: the Auto tool approvals switch now lives under Nightly Experiments (#3207), so restoring the old experimental setting is no longer needed.

@daniel-lxs daniel-lxs closed this Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant