Repository navigation
[Fix] Skills commands wait for remote catalog discovery - #3002
Closed
roomote-roomote[bot] wants to merge 2 commits into
Closed
roomote-roomote[bot] wants to merge 2 commits into
roomote-roomote[bot] wants to merge 2 commits into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 19, 2026 23:56
| throw error; | ||
| }, | ||
| ); | ||
| entry.refresh = Promise.race([operation, timeoutPromise]) |
Contributor
There was a problem hiding this comment.
When the timeout wins this race, operation is still pending, so releaseOperation() has not run. The rejection path records failed, but leaves refreshOperationActive true and keeps the global activeRefreshes slot occupied; this entry consequently never passes the retry condition after retryAfter, and two hung discoveries prevent every other catalog from refreshing. Release the slot and clear the entry's active state on timeout (guarding the later completion), and cover a refresh that never settles.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why this change was made
Production telemetry for the merged skills command showed a Telegram
/skills 2request spending 48.148 seconds in the webhook while its final Telegram send took only 839 ms. The command blocked its first response on remote Settings and repository discovery, then repeated that work for each page.Impact
Cold commands now return a truthful local catalog with an explicit remote-discovery-pending notice; refreshed results cannot shift entries mid-pagination. A controlled cache-core measurement returned the partial snapshot in 0.265 ms while remote discovery remained unresolved, excluding local database/filesystem reads. Full skill instructions still resolve lazily through existing exact invocation paths. Production latency improvement remains unverified until this follow-up is reviewed and deployed.