[Fix] Model list does not scroll inside New Session dialog - #2986
Open
roomote-roomote[bot] wants to merge 1 commit into
Open
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
roomote-roomote
Bot
requested review from
brunobergher,
daniel-lxs and
mrubens
as code owners
September 19, 2026 14:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Make the searchable shared model picker own the active modal layer while open, so wheel and trackpad events reach its portaled list when the picker is nested inside the New Session dialog. Add focused regression coverage for the nested dialog path.
Why this change was made
The dialog scroll lock treated the non-modal model picker portal as outside the dialog content and canceled wheel events, leaving a visibly scrollable long model list stuck at its initial position.
Impact
Long model lists now scroll inside nested modal surfaces without changing search, keyboard selection, or the existing Radix Select path for eight or fewer models. Focused component tests and the repository pre-push checks pass.
Screencasts
The genuine local New Session surface shows the nested searchable list moving from the initial Claude/DeepSeek rows to later GLM/GPT/Grok rows while the overlay remains stable.