Skip to content

[Fix] Automations repeat events when no report qualifies - #2979

Closed
roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/automation-silent-noop-3923ut9hd5p9f
Closed

roomote-roomote[bot] wants to merge 1 commit into
developfrom
fix/automation-silent-noop-3923ut9hd5p9f

Conversation

@roomote-roomote

Copy link
Copy Markdown
Contributor

​Opened on behalf of @mrubens. View the task or mention @roomote-roomote for follow-up asks.

What changed

  • Allow custom automation trigger events to use the existing silent ignore_event path when their prompt says no report qualifies.
  • Keep visibility mandatory for pull-request feedback and conflicts, web task settlements, and wakeups configured to always report.
  • Cover both the parent-event classification and the no-reply settlement path with focused regressions.

Why this change was made

Custom automations can explicitly require silence when a run finds no qualifying result. Their trigger events were nevertheless classified as requiring a user-visible closeout, so the runtime rejected ignore_event; if destination delivery also failed, the same completed occurrence could be redelivered instead of settling silently.

Impact

Automations with strict report gates can now complete a no-op without posting or entering a redelivery loop. Automations that produce a result still report normally, and platform events that inherently require user visibility remain enforced.

@roomote-community

roomote-community Bot commented Sep 19, 2026 •

Copy link
Copy Markdown
Contributor

1 issue outstanding. See task

Reviewed d58a2c9

humanFollowUp?.platformEventVisibility ??
(params.event.type === 'pull_request_feedback' ||
params.event.type === 'pull_request_conflict_detected' ||
params.event.type === 'automation_triggered' ||

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making automation_triggered optional lets the turn settle through ignore_event, but it does not make destination-backed runs silent. buildFastAutomationConversation posts ${automation.name} is running. before this event is enqueued for Discord and Teams (and creates a Discord channel thread); an ignored turn never calls postReply, so that placeholder is left visible and permanently appears to be running. Defer that root until a report is produced, or explicitly remove/update it when the event is ignored.

@roomote-roomote roomote-roomote Bot closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant