Repository navigation
[Fix] Automations repeat events when no report qualifies - #2979
Closed
roomote-roomote[bot] wants to merge 1 commit into
Closed
roomote-roomote[bot] wants to merge 1 commit into
roomote-roomote[bot] wants to merge 1 commit into
Conversation
Contributor
|
1 issue outstanding. See task
Reviewed d58a2c9 |
| humanFollowUp?.platformEventVisibility ?? | ||
| (params.event.type === 'pull_request_feedback' || | ||
| params.event.type === 'pull_request_conflict_detected' || | ||
| params.event.type === 'automation_triggered' || |
Contributor
There was a problem hiding this comment.
Making automation_triggered optional lets the turn settle through ignore_event, but it does not make destination-backed runs silent. buildFastAutomationConversation posts ${automation.name} is running. before this event is enqueued for Discord and Teams (and creates a Discord channel thread); an ignored turn never calls postReply, so that placeholder is left visible and permanently appears to be running. Defer that root until a report is produced, or explicitly remove/update it when the event is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ignore_eventpath when their prompt says no report qualifies.Why this change was made
Custom automations can explicitly require silence when a run finds no qualifying result. Their trigger events were nevertheless classified as requiring a user-visible closeout, so the runtime rejected
ignore_event; if destination delivery also failed, the same completed occurrence could be redelivered instead of settling silently.Impact
Automations with strict report gates can now complete a no-op without posting or entering a redelivery loop. Automations that produce a result still report normally, and platform events that inherently require user visibility remain enforced.