test: cover isMessageSequential grouping rules - #1374
Open
ishan-one8 wants to merge 1 commit into
Open
ishan-one8 wants to merge 1 commit into
ishan-one8 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover isMessageSequential grouping rules with unit tests
Acceptance Criteria fulfillment
packages/layout_editor/src/lib/isMessageSequential.test.js, covering every branch of the grouping rulesgit diffon the source is empty)node:test,node:assert/strict, flattest()callslayout_editorsuite passes locally — 25/25 (17 existing + 8 new)Fixes #1373
Video/Screenshots
Not applicable — no visible change, test file only.
PR Test Details
yarn testinpackages/layout_editor(node --test src/lib/*.test.js) → 25 pass, 0 fail.Behaviours now covered:
tset on either message)groupable: falsealiasThese are not tests that pass when the behaviour is broken. Removing the day-boundary guard from the source (
return isTimeDiffSmall && !isMessageNewDay→return isTimeDiffSmall) makes the last one fail:The source was reverted afterwards — this PR touches no source file.
Note: the day-boundary test uses local-time timestamps rather than UTC
Zstrings on purpose, sinceisSameDaycompares local calendar days.