Repository navigation
fix: set session management remove tokens default backchannel logout to all clients when none specified - #148
Merged
Merged
Conversation
…to all clients when none specified
JoStevensRSK
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If DefaultSessionManagementService.RemoveSessionsAsync was called with no client IDs specified and backchannel logout enabled; no notification would be fired. This should have triggered backchannel logout for all clients used in session.
Type of change
Does this PR introduce a breaking change?
n/a
Testing
Updated unit tests to fail, then fixed the implementation, and manually tested.
LLM Usage
n/a
Other context
closes: #147