Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
patchandthat
approved these changes
Oct 28, 2026
patchandthat
left a comment
patchandthat
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks.
1 of 7 tasks
…n-typ # Conflicts: # src/Open.IdentityServer/src/Services/Default/DefaultBackChannelLogoutService.cs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Back-channel logout tokens are now sent with
typ: logout+jwt, as recommended by OpenID Connect Back-Channel Logout 1.0, section 2.4, instead ofat+jwt.Adds
IdentityServerOptions.LogoutTokenJwtType(defaultlogout+jwt; null or empty usesJWT),IdentityServerConstants.TokenTypes.LogoutTokenand anIdentityServerTools.IssueJwtAsyncoverload that takes a token type. The names and default match Duende IdentityServer, so configuration carries over in either direction.Closes #136
Type of change
Does this PR introduce a breaking change?
Does the change cause a breaking change to any of the following?
The default logout token
typchanges fromat+jwttologout+jwt. Per the research in #136, no common client library breaks. SettingLogoutTokenJwtType = "at+jwt"restores the old behaviour.A subclass of
IdentityServerToolsthat overridesIssueJwtAsync(lifetime, claims)no longer sees logout tokens; they go through the new overload, as in Duende 6.3.0.Testing
New unit tests cover the logout
typ, the option and its fallback, and that access tokens keepat+jwt. A new integration test checks the token posted to a client's back-channel logout URI. Without the new branch inDefaultTokenCreationServicethe logouttyptests fail, and without the empty-value check the fallback test fails. The full unit and integration suites pass.LLM Usage
The
src/changes are written by me. The tests and theoptions.rstentry were drafted with Claude and reviewed by me.Other context
Logout outside a request (#134) was fixed in #142.
mainis merged in here, so the logout token keeps the session's issuer from #142 and also gets the new type.BackChannelLogoutHttpClientswallows exceptions, so assertions insideMockMessageHandler.OnInvokecan't fail a test. The new integration test asserts after the logout instead. The existing assertions inlogout_should_invoke_back_channel_logouthave the same problem.🤖 Generated with Claude Code