Repository navigation
bug: fix session id being regenerated on new logins when session already exists - #139
Merged
Merged
Conversation
Closed
patchandthat
approved these changes
Oct 28, 2026
patchandthat
left a comment
patchandthat
left a comment
Collaborator
There was a problem hiding this comment.
Looks fine, one edit suggested.
jhbritton-RSK
force-pushed
the
bug/sid-changing-on-new-login
branch
from
October 28, 2026 10:24
14052cf to
6a07aae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added preservation of session ID when login occurs again on same client when a session already exists.
Type of change
Does this PR introduce a breaking change?
n/a
Testing
Added two unit tests for change to DefaultUserSession.CreateSessionIdAsync
LLM Usage
n/a
Other context
n/a