Repository navigation
refactor: moved auth ticket deserialiisation into db store and out of ITicketStore implementation - #138
Open
jhbritton-RSK wants to merge 6 commits into
Open
refactor: moved auth ticket deserialiisation into db store and out of ITicketStore implementation #138jhbritton-RSK wants to merge 6 commits into
jhbritton-RSK wants to merge 6 commits into
Conversation
…a seperate serializer service
jhbritton-RSK
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moving the auth ticket deserialisation out of the ITicketStore implementation and into the DB store so the deserialised AuthenticationTicket is available in the server-side session model.
Type of change
Does this PR introduce a breaking change?
n/a
Testing
Updated existing tests to check for deserialisation in the correct place
LLM Usage
n/a
Other context
n/a