feat: axis metadata - #26
Merged
Merged
Conversation
…ics WebSocket Co-authored-by: Copilot <copilot@github.com>
…tions Co-authored-by: Copilot <copilot@github.com>
…r filter service messages, and move detection msgs/srv to robotnik_msgs Co-authored-by: Copilot <copilot@github.com>
RomanRobotnik
approved these changes
Sep 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a major refactor to the AXIS camera ROS package, separating the detection functionality into its own dedicated node and improving the control and configurability of object detectors. It adds new configuration options, documentation, and launch files, and updates dependencies to support the new detection node. The most important changes are grouped and summarized below:
Detection Node Refactor and Separation
axis_ptz_node.pyinto a new, independent ROS node:axis_detection_node.py. The detection client is now a reusable, non-ROS class inaxis_lib/axis_detection.py, and the detection node is installed and launched separately. This decouples PTZ and detection functionality for better modularity. [1] [2] [3]Detector Control Functionality
~activate_detector(typeobject_detection_msgs/ManageDetector) enables/disables publication forperson_detectorandvehicle_detector.~get_detectors_name_list(typerobotnik_msgs/GetStringList) lists available detectors and their states.~detectors_states(typeobject_detection_msgs/DetectorsState) publishes the current state of both detectors.Configuration and Build System Updates
object_detection_msgsas a build, export, and runtime dependency inCMakeLists.txtand (not shown here, but referenced)package.xml. Updatedcatkin_packageandfind_packageaccordingly. [1] [2]axis_f2105re_detection_config.yaml) with options for detector enable/disable, authentication, and channel selection.Documentation and Launch
README.mdwith a comprehensive section on the new detection node, its parameters, topics, services, and runtime behavior. Added a new launch file (axis_detection.launch) for starting the detection node with configurable parameters. [1] [2] [3]docs/copilot/refactor_detection.mdanddocs/copilot/control_detector_status.mdto guide future maintenance and clarify architectural decisions. [1] [2]Testing and Miscellaneous
CMakeLists.txtand recommendations for unit and integration testing in the design docs. [1] [2] [3]data/f2105re.yaml.These changes collectively improve modularity, testability, and operational control of object detection in the AXIS camera ROS package.
Depends on robotnik_msgs: RobotnikAutomation/robotnik_msgs#33