Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The documented walkthrough references a missing http-action-client-example.mjs file, so the advertised client step cannot run.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds HTTP/SSE action documentation and Fibonacci browser demos for JavaScript and TypeScript.
Changes:
- Documents action APIs, SSE, cancellation, and OpenAPI support.
- Adds Fibonacci action servers and browser controls.
- Updates demo configuration, styling, and README guidance.
| File | Summary |
|---|---|
web/README.md |
Documents browser actions and HTTP/SSE usage |
scripts/npmjs-readme.md |
Updates package README action guidance |
README.md |
Updates the web SDK overview |
example/actions/README.md |
Adds an HTTP/SSE action walkthrough |
demo/web/typescript/web.json |
Exposes the Fibonacci action and CORS |
demo/web/typescript/src/style.css |
Adds responsive action styling |
demo/web/typescript/src/main.ts |
Implements typed action controls |
demo/web/typescript/server.ts |
Adds the TypeScript Fibonacci action server |
demo/web/typescript/README.md |
Documents the TypeScript action demo |
demo/web/typescript/index.html |
Adds the Fibonacci action panel |
demo/web/javascript/web.json |
Exposes the Fibonacci action |
demo/web/javascript/runtime.mjs |
Adds the JavaScript Fibonacci action server |
demo/web/javascript/README.md |
Documents the JavaScript action demo |
demo/web/javascript/index.html |
Adds the JavaScript action panel and controls |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| #### 4. HTTP Action Client (`http-action-client-example.mjs`) | ||
|
|
||
| Uses the `rclnodejs/web` SDK to send a Fibonacci goal over HTTP, receive SSE feedback, and print the result and terminal status. The client does not create a ROS node and always closes its HTTP stream. It exits with a nonzero status for request/stream errors or a goal that does not succeed. | ||
|
|
||
| See [HTTP Actions over SSE](#http-actions-over-sse) for the server, runtime, and client commands. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The walkthrough references a missing client file, and both browser demos remain disconnected after a back-forward-cache restore.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The TypeScript demo passes null to a parameter that only accepts a callback or undefined, causing strict type-checking to fail.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1


Uh oh!
There was an error while loading. Please reload this page.