build(cmake): fix target name for RS_JEREMY_RIFKIN_CPPTRACE definition - #384
Open
jolavillette wants to merge 1 commit into
Open
build(cmake): fix target name for RS_JEREMY_RIFKIN_CPPTRACE definition#384jolavillette wants to merge 1 commit into
jolavillette wants to merge 1 commit into
Conversation
When RS_CPPTRACE_STACKTRACE is enabled, target_compile_definitions referenced ${LIBRARY_NAME}, which is undefined in this scope. Consequently, RS_JEREMY_RIFKIN_CPPTRACE was never passed to the compiler and rsstacktrace.cc could never use cpptrace.
Target should be ${PROJECT_NAME} (retroshare), matching target_link_libraries on the preceding line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When building with
-DRS_CPPTRACE_STACKTRACE=ON,target_compile_definitions()referenced${LIBRARY_NAME}, which is undefined in this scope.As a result:
-DRS_JEREMY_RIFKIN_CPPTRACEwas never passed to the compiler.rsstacktrace.ccsilently ignoredcpptrace(even though the library was fetched and linked).Fix by using
${PROJECT_NAME}(matchingtarget_link_librarieson the previous line).