cleenup code & fixes - #23
Open
defnax wants to merge 1 commit into
Open
Conversation
- Null check on `dynamic_cast` in `recvItem()` - OOB read guard in `deserialise()` - Null guards for `rsIdentity`/`rsPeers`/`rsChats` in constructors & `autoJoinOfficialLobby()` - Chess invite now only shows in the correct chat window (uncommented peer check) - Lobby chat no longer posts malformed messages - Plugin destructor cleans up allocated members - Thread-safe init with `std::call_once` - Proper widget cleanup in `clearInviteButtons()` and `closeAll()` - QToolButton now has a parent - Removed dead code (`ping_all`, unused `flag`/`retVal`) - Removed redundant `data_size` wire field - Eliminated double string copy in JSON parsing - Safer `QMessageBox` parent in rematch dialog - Restored the legacy wire field, deriving its value from the message size. - Moved the destructor into the .cpp so toaster cleanup runs correctly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dynamic_castinrecvItem()deserialise()rsIdentity/rsPeers/rsChatsin constructors &autoJoinOfficialLobby()std::call_onceclearInviteButtons()andcloseAll()ping_all, unusedflag/retVal)data_sizewire fieldQMessageBoxparent in rematch dialog