Refactor Main() into dedicated classes and fix startup bugs - #48
Open
goldorakiller wants to merge 1 commit into
Open
Refactor Main() into dedicated classes and fix startup bugs#48goldorakiller wants to merge 1 commit into
goldorakiller wants to merge 1 commit into
Conversation
- Fix: propagate --external-launcher to the intro video, so it no longer
forces focus back to EmulationStation when launched from an external
frontend.
- Fix: align FocusDelay/VideoDelay fallback defaults with the values
written to the default retrobat.ini (previously inconsistent).
- Fix: preserve original exception stack trace in IniFile's constructor
(`throw ex;` -> `throw;`).
- Cleanup: remove RawInput.cs (dead code, never referenced) and the
orphaned SharpDX packages.config entry (no longer referenced by the
project).
- Cleanup: replace empty `catch { }` blocks with logged warnings across
Program.cs, SplashVideo.cs and VideoPlayerForm.cs.
- Refactor: split the ~900-line Main() into focused, testable classes:
StartupFileChecker, RetroBatConfigLoader, AutostartManager,
DpiAwarenessManager, EmulationStationSettings and
EmulationStationLauncher. Behavior is preserved, including edge cases
(early return when EmulationStation fails to start still skips the
final success log, same as before).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
throw ex;->throw;).catch { }blocks with logged warnings across Program.cs, SplashVideo.cs and VideoPlayerForm.cs.