fix(env): upgrade Cloud Agent Dockerfile to PHP 8.4 - #144
Merged
Conversation
composer.lock pins Symfony 8.1 packages that require PHP >=8.4.1. The previous PHP 8.3 image caused composer install to fail during Cloud Agent environment setup. Co-authored-by: Soham Banerjee <soham@renderbit.com>
soham2008xyz
marked this pull request as ready for review
August 6, 2026 13:10
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Cloud Agent Dockerfile to install PHP 8.4 (via the ondrej/php PPA) on Ubuntu 24.04, aligning the agent environment with the project’s current composer.lock requirements so composer install can succeed during environment provisioning.
Changes:
- Add
software-properties-commonand registerppa:ondrej/phpto access PHP 8.4 packages on Ubuntu 24.04. - Replace PHP 8.3 package installs with PHP 8.4 extensions required by the app.
- Leave Node.js 22 and Composer installation flow unchanged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the Cloud Agent base image from PHP 8.3 to PHP 8.4 so
composer installsucceeds against the current lockfile.Symfony 8.1 packages in
composer.lockrequire PHP>=8.4.1. The previous Dockerfile installed PHP 8.3 from Ubuntu defaults, which caused environment setup to fail duringbash .cursor/install.sh.Changes
ondrej/phpPPA and install PHP 8.4 extensions (replacing PHP 8.3 packages)Validation
Environment setup was tested end-to-end on this branch:
bash .cursor/install.sh— passed twice (idempotent)vendor/bin/pint --test— passedcomposer test— 2 tests passedphp artisan serveon port 8000 — homepage HTTP 200artisan tinker— succeededbld-20260806-50d3c92c-83f0-4400-b4eb-1fa96dffe5f1— 8/8 checks passedNote
Merge this PR to
masterbefore triggering a promotable default-branch environment build. The tested draft build used this branch ref.