Skip to content

TESTING: scale the xGEEV eigenvalue-consistency check by n ulp |W| #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
langou merged 1 commit into from
Sep 12, 2026
Merged

TESTING: scale the xGEEV eigenvalue-consistency check by n ulp |W| #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 23 additions & 9 deletions TESTING/EIG/cdrvev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ SUBROUTINE CDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ JTYPE, MTYPES, N, NERRS, NFAIL, NMAX,
$ NNWORK, NTEST, NTESTF, NTESTT
REAL ANORM, COND, CONDS, OVFL, RTULP, RTULPI, TNRM,
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST, WDIF, WNRM
* ..
* .. Local Arrays ..
INTEGER IDUMMA( 1 ), IOLDSD( 4 ), KCONDS( MAXTYP ),
Expand Down Expand Up @@ -799,10 +799,15 @@ SUBROUTINE CDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5)
*
WNRM = ZERO
WDIF = ZERO
DO 150 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
150 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Compute eigenvalues and right eigenvectors, and test them
*
Expand All @@ -819,10 +824,15 @@ SUBROUTINE CDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 160 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
160 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (6)
*
Expand All @@ -848,10 +858,15 @@ SUBROUTINE CDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 190 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
190 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (7)
*
Expand Down Expand Up @@ -932,8 +947,7 @@ SUBROUTINE CDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | conj-trans(A) VL - VL conj-trans(W) | /',
$ ' ( n |A| ulp ) ', / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter if VL computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter if VR computed,',
Expand Down
3 changes: 1 addition & 2 deletions TESTING/EIG/cdrvvx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -969,8 +969,7 @@ SUBROUTINE CDRVVX( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | transpose(A) VL - VL W | / ( n |A| ulp ) ',
$ / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter what else computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter what else computed,',
Expand Down
29 changes: 22 additions & 7 deletions TESTING/EIG/cget23.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,7 @@ SUBROUTINE CGET23( COMP, ISRT, BALANC, JTYPE, THRESH, ISEED,
$ J, JJ, KMIN
REAL ABNRM, ABNRM1, EPS, SMLNUM, TNRM, TOL, TOLIN,
$ ULP, ULPINV, V, VMAX, VMX, VRICMP, VRIMIN,
$ VRMX, VTST
$ VRMX, VTST, WDIF, WNRM
COMPLEX CTMP
* ..
* .. Local Arrays ..
Expand Down Expand Up @@ -580,10 +580,15 @@ SUBROUTINE CGET23( COMP, ISRT, BALANC, JTYPE, THRESH, ISEED,
*
* Do Test (5)
*
WNRM = ZERO
WDIF = ZERO
DO 60 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
60 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (8)
*
Expand Down Expand Up @@ -630,10 +635,15 @@ SUBROUTINE CGET23( COMP, ISRT, BALANC, JTYPE, THRESH, ISEED,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 90 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
90 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (6)
*
Expand Down Expand Up @@ -689,10 +699,15 @@ SUBROUTINE CGET23( COMP, ISRT, BALANC, JTYPE, THRESH, ISEED,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 140 J = 1, N
IF( W( J ).NE.W1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( W( J ) ), ABS( W1( J ) ) )
WDIF = MAX( WDIF, ABS( W( J )-W1( J ) ) )
140 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (7)
*
Expand Down
38 changes: 29 additions & 9 deletions TESTING/EIG/ddrvev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ SUBROUTINE DDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ JTYPE, MTYPES, N, NERRS, NFAIL, NMAX, NNWORK,
$ NTEST, NTESTF, NTESTT
DOUBLE PRECISION ANORM, COND, CONDS, OVFL, RTULP, RTULPI, TNRM,
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST, WDIF, WNRM
* ..
* .. Local Arrays ..
CHARACTER ADUMMA( 1 )
Expand Down Expand Up @@ -827,10 +827,17 @@ SUBROUTINE DDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5)
*
WNRM = ZERO
WDIF = ZERO
DO 150 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
150 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Compute eigenvalues and right eigenvectors, and test them
*
Expand All @@ -847,10 +854,17 @@ SUBROUTINE DDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 160 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
160 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (6)
*
Expand All @@ -876,10 +890,17 @@ SUBROUTINE DDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 190 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
190 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (7)
*
Expand Down Expand Up @@ -959,8 +980,7 @@ SUBROUTINE DDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | transpose(A) VL - VL W | / ( n |A| ulp ) ',
$ / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter if VL computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter if VR computed,',
Expand Down
3 changes: 1 addition & 2 deletions TESTING/EIG/ddrvvx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,8 +991,7 @@ SUBROUTINE DDRVVX( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | transpose(A) VL - VL W | / ( n |A| ulp ) ',
$ / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter what else computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter what else computed,',
Expand Down
35 changes: 28 additions & 7 deletions TESTING/EIG/dget23.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ SUBROUTINE DGET23( COMP, BALANC, JTYPE, THRESH, ISEED, NOUNIT, N,
$ J, JJ, KMIN
DOUBLE PRECISION ABNRM, ABNRM1, EPS, SMLNUM, TNRM, TOL, TOLIN,
$ ULP, ULPINV, V, VIMIN, VMAX, VMX, VRMIN, VRMX,
$ VTST
$ VTST, WDIF, WNRM
* ..
* .. Local Arrays ..
CHARACTER SENS( 2 )
Expand Down Expand Up @@ -600,10 +600,17 @@ SUBROUTINE DGET23( COMP, BALANC, JTYPE, THRESH, ISEED, NOUNIT, N,
*
* Do Test (5)
*
WNRM = ZERO
WDIF = ZERO
DO 60 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
60 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (8)
*
Expand Down Expand Up @@ -650,10 +657,17 @@ SUBROUTINE DGET23( COMP, BALANC, JTYPE, THRESH, ISEED, NOUNIT, N,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 90 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
90 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (6)
*
Expand Down Expand Up @@ -709,10 +723,17 @@ SUBROUTINE DGET23( COMP, BALANC, JTYPE, THRESH, ISEED, NOUNIT, N,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 140 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
140 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( SMLNUM, ULP*DBLE( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (7)
*
Expand Down
38 changes: 29 additions & 9 deletions TESTING/EIG/sdrvev.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,7 @@ SUBROUTINE SDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ JTYPE, MTYPES, N, NERRS, NFAIL, NMAX,
$ NNWORK, NTEST, NTESTF, NTESTT
REAL ANORM, COND, CONDS, OVFL, RTULP, RTULPI, TNRM,
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST
$ ULP, ULPINV, UNFL, VMX, VRMX, VTST, WDIF, WNRM
* ..
* .. Local Arrays ..
CHARACTER ADUMMA( 1 )
Expand Down Expand Up @@ -827,10 +827,17 @@ SUBROUTINE SDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5)
*
WNRM = ZERO
WDIF = ZERO
DO 150 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
150 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Compute eigenvalues and right eigenvectors, and test them
*
Expand All @@ -847,10 +854,17 @@ SUBROUTINE SDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 160 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
160 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (6)
*
Expand All @@ -876,10 +890,17 @@ SUBROUTINE SDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
*
* Do Test (5) again
*
WNRM = ZERO
WDIF = ZERO
DO 190 J = 1, N
IF( WR( J ).NE.WR1( J ) .OR. WI( J ).NE.WI1( J ) )
$ RESULT( 5 ) = ULPINV
WNRM = MAX( WNRM, ABS( WR( J ) )+ABS( WI( J ) ),
$ ABS( WR1( J ) )+ABS( WI1( J ) ) )
WDIF = MAX( WDIF, ABS( WR( J )-WR1( J ) )+
$ ABS( WI( J )-WI1( J ) ) )
190 CONTINUE
RESULT( 5 ) = MAX( RESULT( 5 ), WDIF /
$ MAX( UNFL, ULP*REAL( N )*
$ MAX( WNRM, WDIF ) ) )
*
* Do Test (7)
*
Expand Down Expand Up @@ -959,8 +980,7 @@ SUBROUTINE SDRVEV( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | transpose(A) VL - VL W | / ( n |A| ulp ) ',
$ / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter if VL computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter if VR computed,',
Expand Down
3 changes: 1 addition & 2 deletions TESTING/EIG/sdrvvx.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -990,8 +990,7 @@ SUBROUTINE SDRVVX( NSIZES, NN, NTYPES, DOTYPE, ISEED, THRESH,
$ / ' 2 = | transpose(A) VL - VL W | / ( n |A| ulp ) ',
$ / ' 3 = | |VR(i)| - 1 | / ulp ',
$ / ' 4 = | |VL(i)| - 1 | / ulp ',
$ / ' 5 = 0 if W same no matter if VR or VL computed,',
$ ' 1/ulp otherwise', /
$ / ' 5 = | W - W(other JOBVL/JOBVR) | / ( n |W| ulp ) ', /
$ ' 6 = 0 if VR same no matter what else computed,',
$ ' 1/ulp otherwise', /
$ ' 7 = 0 if VL same no matter what else computed,',
Expand Down
Loading
Loading