Move script name to top - #1342
Conversation
WalkthroughThe script editor now shows the active script or help name in a centered toolbar label. The method filter shares a row with alphabetical sorting. Obsolete filename and script icon members and update logic were removed. ChangesScript editor toolbar
Estimated code review effort: 3 (Moderate) | ~15 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
scriptname.mp4 |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@editor/script/script_editor_plugin.cpp`:
- Around line 747-759: Update the active-tab handling in _go_to_tab() and the
related refresh/selection paths to synchronize script_name_label from the
unfiltered current ScriptEditorBase tab before applying filter_scripts. Use the
current script’s name for an active tab, including hidden, renamed,
history-selected, or refreshed scripts, and clear the label when no tab is
active.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: e8d7390d-bf92-4eee-a8b5-2973cca0d2b6
📒 Files selected for processing (2)
editor/script/script_editor_plugin.cppeditor/script/script_editor_plugin.h
💤 Files with no reviewable changes (1)
- editor/script/script_editor_plugin.h

Cherry-pick from godotengine/godot@206d4a0.
The previous cherry-pick (#1239) hit a regression.
Summary by CodeRabbit