Skip to content

Sync Safe config with api-kit 5.0.3 and add ADI Chain #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aviggiano merged 3 commits into from
Oct 14, 2026
Merged

Sync Safe config with api-kit 5.0.3 and add ADI Chain #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fccbd17
Sync Safe config with api-kit 5.0.3 and add ADI Chain
lemunozm Oct 13, 2026
a3de4f7
Format for forge 1.8.5, the current stable CI installs
lemunozm Oct 13, 2026
d8197da
Keep MultiSendCallOnly for chains whose transaction service was retired
lemunozm Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
152 changes: 96 additions & 56 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "safe-utils",
"devDependencies": {
"@safe-global/api-kit": "4.1.0",
"@safe-global/safe-deployments": "1.37.53"
"@safe-global/api-kit": "5.0.3",

@aviggiano aviggiano Oct 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a major bump (4.1.0 → 5.0.3), and both FFI scripts depend on regex-scraping var networks = [...] out of the built bundle. That coupling to bundler output is fragile across majors. Not blocking if it works today, but worth either pinning tightly with a comment or switching to a stable exported API if 5.x provides one.

@lemunozm lemunozm Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked: 5.0.3 exports only the client and HttpError, no network list, so the scrape has to stay. It's pinned exactly and both scripts now say why.

"@safe-global/safe-deployments": "1.37.63"
}
}
Loading
Loading