Skip to content

Guard Microsoft Update Catalog row parsing against null table cells #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Guard Microsoft Update Catalog row parsing against null table cells #25

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c14d58
Initial plan
Copilot Aug 1, 2026
614f22b
fix(deployment): guard null catalog table cells
Copilot Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions OSDCloud/private/microsoft-update-catalog/Get-MicrosoftUpdateCatalogResult.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,8 +250,13 @@ function Get-MicrosoftUpdateCatalogResult {
#region Base Filtering
# Apply base filters with improved logic
$Rows = $Rows.Where({
$title = $_.SelectNodes("td")[1].InnerText.Trim()
$classification = $_.SelectNodes("td")[3].InnerText.Trim()
$cells = $_.SelectNodes("td")
if ($null -eq $cells -or $cells.Count -lt 4) {
return $false
}

$title = [string]$cells[1].InnerText
$classification = [string]$cells[3].InnerText
$include = $true


Expand Down Expand Up @@ -367,7 +372,12 @@ function Get-MicrosoftUpdateCatalogResult {
# Apply architecture filter with improved logic
if ($Architecture -ne "all") {
$Rows = $Rows.Where({
$title = $_.SelectNodes("td")[1].InnerText.Trim()
$cells = $_.SelectNodes("td")
if ($null -eq $cells -or $cells.Count -lt 2) {
return $false
}

$title = [string]$cells[1].InnerText
switch ($Architecture) {
"x64" { $title -match "x64|64.?bit|64.?based" -and -not ($title -match "x86|32.?bit|arm64") }
"x86" { $title -match "x86|32.?bit|32.?based" -and -not ($title -match "64.?bit|arm64") }
Expand Down