Skip to content

4.x: Isolate Maybe timeout race tests - #8321

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
JimmyLiuJia:codex/maintenance/8075-maybe-timeout-isolation-refresh
Oct 12, 2026
Merged

akarnokd merged 1 commit into
ReactiveX:4.xfrom
JimmyLiuJia:codex/maintenance/8075-maybe-timeout-isolation-refresh

Conversation

@JimmyLiuJia

Copy link
Copy Markdown
Contributor

Related #8075.

Move onErrorRace and onCompleteRace from MaybeTimeoutTest and MaybeTimeoutPublisherTest into their corresponding IsolatedTest classes, following the naming requested in the issue. The four methods keep their bodies, assertions, race loops and cleanup unchanged; all 38 existing test methods are preserved. This is a movements-only batch, with no production or test-runner configuration changes.

The new classes use JUnit @Isolated, so these race tests do not overlap with other classes when same-JVM parallel execution is enabled. In particular, onErrorRace installs the shared RxJavaPlugins error handler. No default-baseline failure or full-suite parallel stability is claimed.

Verified locally on Windows with OpenJDK 26.0.2.1 and Gradle 9.8.0:

  • gradle test --tests "io.reactivex.rxjava4.internal.operators.maybe.MaybeTimeout*" --stacktrace --no-daemon: 38 passed before and after the move; inherited disabled tests account for 2 and 4 skips.
  • gradle test --tests "io.reactivex.rxjava4.validators.*" --stacktrace --no-daemon: 272 passed, 27 skipped.
  • gradle build --stacktrace --no-daemon --rerun-tasks: passed, including JUnit (13,368 passed, 871 skipped), TestNG/TCK (4,001 passed, 1,795 skipped), Checkstyle and JaCoCo.
  • gradle javadoc --stacktrace --no-daemon and git diff --check: passed.

The first full build hit CompletableIsolatedTest.repeatNormal (expected 6 calls, observed 5). That unmodified test passed alone on the clean target baseline; the subsequent complete build passed with the original settings and every task rerun. Both results were retained. Upstream Ubuntu/Zulu CI remains separate from this local validation.

AI assistance was used to prepare and check this change.

@github-actions

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 4.768 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutIsolatedTest.java: 4.786
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherIsolatedTest.java: 4.784
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutPublisherTest.java: 4.739
src/test/java/io/reactivex/rxjava4/internal/operators/maybe/MaybeTimeoutTest.java: 4.764

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.62%. Comparing base (9cb9e1b) to head (3442b3e).

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8321      +/-   ##
============================================
+ Coverage     98.60%   98.62%   +0.01%     
+ Complexity     7157     7155       -2     
============================================
  Files           824      824              
  Lines         50822    50822              
  Branches       6920     6920              
============================================
+ Hits          50115    50124       +9     
+ Misses          475      468       -7     
+ Partials        232      230       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd
akarnokd merged commit 043558c into ReactiveX:4.x Oct 12, 2026
8 checks passed
@akarnokd akarnokd added this to the 4.0 milestone Oct 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants