Repository navigation
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 4.768 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8321 +/- ##
============================================
+ Coverage 98.60% 98.62% +0.01%
+ Complexity 7157 7155 -2
============================================
Files 824 824
Lines 50822 50822
Branches 6920 6920
============================================
+ Hits 50115 50124 +9
+ Misses 475 468 -7
+ Partials 232 230 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
akarnokd
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #8075.
Move
onErrorRaceandonCompleteRacefromMaybeTimeoutTestandMaybeTimeoutPublisherTestinto their correspondingIsolatedTestclasses, following the naming requested in the issue. The four methods keep their bodies, assertions, race loops and cleanup unchanged; all 38 existing test methods are preserved. This is a movements-only batch, with no production or test-runner configuration changes.The new classes use JUnit
@Isolated, so these race tests do not overlap with other classes when same-JVM parallel execution is enabled. In particular,onErrorRaceinstalls the shared RxJavaPlugins error handler. No default-baseline failure or full-suite parallel stability is claimed.Verified locally on Windows with OpenJDK 26.0.2.1 and Gradle 9.8.0:
gradle test --tests "io.reactivex.rxjava4.internal.operators.maybe.MaybeTimeout*" --stacktrace --no-daemon: 38 passed before and after the move; inherited disabled tests account for 2 and 4 skips.gradle test --tests "io.reactivex.rxjava4.validators.*" --stacktrace --no-daemon: 272 passed, 27 skipped.gradle build --stacktrace --no-daemon --rerun-tasks: passed, including JUnit (13,368 passed, 871 skipped), TestNG/TCK (4,001 passed, 1,795 skipped), Checkstyle and JaCoCo.gradle javadoc --stacktrace --no-daemonandgit diff --check: passed.The first full build hit
CompletableIsolatedTest.repeatNormal(expected 6 calls, observed 5). That unmodified test passed alone on the clean target baseline; the subsequent complete build passed with the original settings and every task rerun. Both results were retained. Upstream Ubuntu/Zulu CI remains separate from this local validation.AI assistance was used to prepare and check this change.