Skip to content

4.x: Streamable ~ separate streamer cancellation & DisposableContainer#8223

Merged
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xStreamerCancellationReworrk
Jul 8, 2026
Merged

4.x: Streamable ~ separate streamer cancellation & DisposableContainer#8223
akarnokd merged 1 commit into
ReactiveX:4.xfrom
akarnokd:4xStreamerCancellationReworrk

Conversation

@akarnokd

@akarnokd akarnokd commented Jul 8, 2026

Copy link
Copy Markdown
Member

The original idea of having StreamerCancellation -> DisposableContainer conflated the two use cases. Former is for Streamer and sub-Streamer management, the latter is a generic resource storage.

Now we have DisposableStreamerCancellation that extends Disposable and thus can be mass cancelled.

reset and clear still not supported because it would allow removing other's disposables and thus causing possible hangs.

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

🐷 TruffleHog + Entropy Beauty Scan

Average entropy of changed code: 5.094 bits/char
Verdict: ⚠️ Consider review — entropy outside sweet spot

Changed files entropy:

.github/workflows/gradle_branch.yml: 5.094
.github/workflows/gradle_pr.yml: 4.942
.github/workflows/gradle_preview_jdks.yml: 5.147
.github/workflows/gradle_release.yml: 5.219
.github/workflows/gradle_snapshot.yml: 5.068

✅ No secrets or suspicious high-entropy strings found.

Mid-4 beauty heuristic in action — powered by our entropy chats! 😊

@codecov

codecov Bot commented Jul 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.67%. Comparing base (c5f1557) to head (82466f2).
⚠️ Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@             Coverage Diff              @@
##                4.x    #8223      +/-   ##
============================================
- Coverage     98.69%   98.67%   -0.02%     
  Complexity     7097     7097              
============================================
  Files           813      813              
  Lines         50017    50017              
  Branches       6764     6764              
============================================
- Hits          49365    49356       -9     
- Misses          450      456       +6     
- Partials        202      205       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@akarnokd akarnokd merged commit 97b7d04 into ReactiveX:4.x Jul 8, 2026
6 checks passed
@akarnokd akarnokd deleted the 4xStreamerCancellationReworrk branch July 8, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant