4.x: Streamable ~ separate streamer cancellation & DisposableContainer#8223
Merged
Merged
Conversation
🐷 TruffleHog + Entropy Beauty ScanAverage entropy of changed code: 5.094 bits/char Changed files entropy: ✅ No secrets or suspicious high-entropy strings found. Mid-4 beauty heuristic in action — powered by our entropy chats! 😊 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.x #8223 +/- ##
============================================
- Coverage 98.69% 98.67% -0.02%
Complexity 7097 7097
============================================
Files 813 813
Lines 50017 50017
Branches 6764 6764
============================================
- Hits 49365 49356 -9
- Misses 450 456 +6
- Partials 202 205 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original idea of having
StreamerCancellation->DisposableContainerconflated the two use cases. Former is forStreamerand sub-Streamermanagement, the latter is a generic resource storage.Now we have
DisposableStreamerCancellationthat extendsDisposableand thus can be mass cancelled.resetandclearstill not supported because it would allow removing other's disposables and thus causing possible hangs.