Skip to content

Remove GitHub Packages config now Scratch comes from public npm, remo… - #1647

Merged
jamiebenstead merged 4 commits into
mainfrom
remove-github-packages-config
Sep 22, 2026
Merged

jamiebenstead merged 4 commits into
mainfrom
remove-github-packages-config

Conversation

@jamiebenstead

Copy link
Copy Markdown
Contributor

Copilot AI lite review requested due to automatic review settings September 21, 2026 13:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The tracked .npmrc still routes the Raspberry Pi Foundation scope through GitHub Packages and references NPM_AUTH_TOKEN.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity

Open (1)
What changed in this PR

Removes obsolete GitHub Packages authentication and local Scratch linking documentation now that Scratch GUI uses public npm.

Changes:

  • Removes registry authentication from Yarn, Docker, and CI/CD.
  • Updates installation documentation.
  • Deletes outdated Scratch editor linking instructions.
File Description
README.md Removes private registry and linking guidance.
docs/​linking-scratch-editor.md Deletes obsolete local-linking documentation.
docker-compose.yml Removes package authentication environment variable.
.yarnrc.yml Removes GitHub Packages registry configuration.
.github/​workflows/​deploy.yml Removes deployment registry authentication.
.github/​workflows/​ci-cd.yml Removes CI registry authentication.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread README.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Two CI jobs retain empty env: keys that GitHub Actions will reject as null mappings.

Get a fresh assessment by requesting another Copilot review.

Review effort: Balanced
Findings: 1 High severity

Open (1)
Resolved since last review (1)

Comment thread .github/workflows/ci-cd.yml Outdated

@zetter-rpf zetter-rpf left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamiebenstead thanks for tidying up

There are a couple of bits in src/components/Menus/Sidebar/InfoPanel/InfoPanel.jsx with the license that are no longer accurate that might be good to change. I think the two lines/paragraphs to remove are:

"Modified 2026 by the Raspberry Pi Foundation"

"See modified source code and full licence...."

@jamiebenstead

Copy link
Copy Markdown
Contributor Author

@jamiebenstead thanks for tidying up

There are a couple of bits in src/components/Menus/Sidebar/InfoPanel/InfoPanel.jsx with the license that are no longer accurate that might be good to change. I think the two lines/paragraphs to remove are:

"Modified 2026 by the Raspberry Pi Foundation"

"See modified source code and full licence...."

Good shout, I'll sort these out

@jamiebenstead
jamiebenstead merged commit 7c7b481 into main Sep 22, 2026
11 checks passed
@jamiebenstead
jamiebenstead deleted the remove-github-packages-config branch September 22, 2026 10:02

This branch was successfully deployed

1 active deployment
previews/1647/merge — 4a77d163 Deployed Sep 22, 2026 by jamiebenstead via deploy-branch / build-deploy #6765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants