Skip to content

Revert "keep Scratch block pills whole when instructions wrap" - #1642

Merged
maxelkins merged 1 commit into
mainfrom
revert-1637-scratch-block-wrapping
Sep 15, 2026
Merged

maxelkins merged 1 commit into
mainfrom
revert-1637-scratch-block-wrapping

Conversation

@maxelkins

@maxelkins maxelkins commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Reverts #1637.

This removes the inline-block styling and margin added for Scratch block pills.

@zetter-rpf

Copy link
Copy Markdown
Contributor

The current solution doesn't actually address this issue since the text is still breaking.

I've seen cases where the text fits on one line so this does prevent wapping in the block for thoose.

In this case I believe that this require a content change rather than a design change:

For the ExCS migration we said we want to avoid having to change content. As well putting a burden on the content authors, there are a lot of existing remixed projects that aren't going to be able to be updated.

I think the key issue is if we're happy with the wrapping or not. I don't have an opinion about this, but I think you should talk to the person who raised the issue.

@maxelkins

maxelkins commented Sep 15, 2026

Copy link
Copy Markdown
Contributor Author

For the ExCS migration we said we want to avoid having to change content. As well putting a burden on the content authors, there are a lot of existing remixed projects that aren't going to be able to be updated.

Understood, I'm not suggesting we need to change anything for the migration. The way it was working was the same as the current ExCS behaviour.

I think the wrapping is fine, and more readable than creating empty spaces in the text.

Happy to talk to the team

@zetter-rpf

zetter-rpf commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

The way it was working was the same as the current ExCS behaviour

That's not true. The blocks in ExCS go onto a new line to avoid wrapping mid block. They are also much smaller as they don't use a fixed width font.

@maxelkins
maxelkins force-pushed the revert-1637-scratch-block-wrapping branch from 5b491e5 to 8e77b44 Compare September 15, 2026 11:10
@maxelkins maxelkins changed the title Revert "keep Scratch block pills whole when instructions wrap" Allow long Scratch block pills to wrap Sep 15, 2026
@maxelkins
maxelkins force-pushed the revert-1637-scratch-block-wrapping branch from 8e77b44 to 5b491e5 Compare September 15, 2026 11:11
@maxelkins maxelkins changed the title Allow long Scratch block pills to wrap Revert "keep Scratch block pills whole when instructions wrap" Sep 15, 2026
@maxelkins
maxelkins marked this pull request as draft September 15, 2026 11:42
@maxelkins
maxelkins marked this pull request as ready for review September 15, 2026 13:27
@maxelkins

Copy link
Copy Markdown
Contributor Author

The blocks in ExCS go onto a new line to avoid wrapping mid block

Ah, thanks for clarifying, I think I was thinking of Code Club Projects.


After thinking it through again with the additional feedback (very helpful thank you) I was leaning towards keeping this change - since both thinks can be true: its helpful that these blocks wrap, but we can also encourage content authors to keep them short and use other display methods.

However I do still think it creates some odd visuals and wrapping which creates big empty spaces, widowed punctuaction etc.

For example:

Screenshot 2026-09-15 at 14 14 15

vs

Screenshot 2026-09-15 at 14 14 05

I also looked at a few other sites to see how they handle this, and of the few I looked at they all seem to wrap how we initially implemented it (see below).

Free Code Camp:

Screenshot 2026-09-15 at 14 57 05

Code Academy:

Screenshot 2026-09-15 at 14 58 38

Github:

Screenshot 2026-09-15 at 15 02 17

Conclusion

For now, I think the original wrapping creates more readable instructions.

In addition, future interations of instructions should look to utilise other ways of writing content i.e. code blocks or rendered scratch blocks. (With the understanding that instructions currently remixed will not be updated, but still legible with the wrapping).

For example:

Screenshot 2026-09-15 at 14 19 24

I'll reach out to the Experience CS team to talk about this change and how we could adapt instructions and/or other ways we could improve the design


Side note:

ExCS also doesn't have a resizable panel and relies on fixed widths, if the content is too long then it overflows, which is addressed in both solutions 👍

Screenshot 2026-09-15 at 11 22 32

@maxelkins
maxelkins merged commit fc8937b into main Sep 15, 2026
21 checks passed
@maxelkins
maxelkins deleted the revert-1637-scratch-block-wrapping branch September 15, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants