Load projects in the correct locale - #1633
Merged
Merged
Conversation
zetter-rpf
temporarily deployed
to
previews/1633/merge
September 10, 2026 15:08 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
zetter-rpf
force-pushed
the
load-projects-in-correct-locale
branch
from
September 10, 2026 15:13
e6552c6 to
c26cedb
Compare
zetter-rpf
temporarily deployed
to
previews/1633/merge
September 10, 2026 15:13 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
zetter-rpf
marked this pull request as ready for review
September 10, 2026 15:14
Some project identifiers are shared between locales, this is the case for the Experience CS preview page. We need to send the locale with the request to load the correct project. Note that we could alternatively set cookies and send them with the request (this is what ExCS does). This doesn't apply to saving yet as editable projects only exist in one locale for now.
zetter-rpf
force-pushed
the
load-projects-in-correct-locale
branch
from
September 10, 2026 15:26
c26cedb to
6a08fb3
Compare
mwtrew
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to: https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/1800
Corresponding API PR: RaspberryPiFoundation/editor-api#1010
Some project identifiers are shared between locales, this is the case for the Experience CS preview page. We need to send the locale with the request to load the correct project.
Note that we could alternatively set cookies and send them with the request (this is what ExCS does).
This doesn't apply to saving yet as editable projects only exist in one locale for now.