Repository navigation
docs: note that number fields accept Infinity - #10679
Merged
gonfunko merged 1 commit intoNov 12, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Welcome! It looks like this is your first pull request in Blockly, so here are a couple of tips:
- You can find tips about contributing to Blockly and how to validate your changes on our developer site.
- We use conventional commits to make versioning the package easier. Make sure your commit message is in the proper format or learn how to fix it.
- If any of the other checks on this PR fail, you can click on them to learn why. It might be that your change caused a test failure, or that you need to double-check the style guide.
Thank you for opening this PR! A member of the Blockly team will review it soon.
Contributor
|
Thanks for the PR! This looks good to go. |
gonfunko
approved these changes
Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #4784
Proposed Changes
Adds a short note under the "Constraints" heading of the Number fields guide explaining that number fields accept
Infinity/-Infinity(case-insensitive), and that settingminandmaxclamps infinite values to those limits.Reason for Changes
Accepting infinity is the default behaviour but wasn't documented, which surprised developers expecting finite input (see #4784). Implements the docs change suggested by @zspriggs in the issue.
Test Coverage
Docs-only change. Checked the rendered Markdown in the GitHub preview, and verified the described behaviour against
FieldNumber.doClassValidation_incore/field_number.ts: "infinity" is matched case-insensitively and the value is clamped tomin/max.Documentation
This PR is the documentation update.
Additional Information
None.