test: Remove logspam when running test suite - #10392
Open
gonfunko wants to merge 1 commit into
Open
Conversation
maribethb
approved these changes
Sep 9, 2026
| }); | ||
| Blockly.common.defineBlocks(p5blocks); | ||
| if (!('p5_setup' in Blockly.Blocks)) { | ||
| Blockly.common.defineBlocks(p5blocks); |
Contributor
There was a problem hiding this comment.
I think ideally these tests that register blocks should unregister them at the end of their tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR avoids several thousand lines of errors and warnings in the devtools console when running the Mocha test suite. There are now less than a dozen warnings from when tests actually try to do naughty things.
These changes fall into several buckets:
There are also a few core changes. While these mostly show up in a test context, they all could happen during actual use, so I think the changes are justified:
FieldInput.resizeEditor_is more defensive instead of force unwrapping theWidgetDivWorkspaceAudiomanager is more defensive and only attempts to play audio when not suspended by the browserReason for Changes
Less logspam makes debugging new tests easier and increases the likelihood that important log messages from the test suite are noticed and acted upon.