fix: Fix bug that caused getInitialCandidate() to be called on every drag step#10157
Merged
Conversation
lizschwab
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
This PR fixes a bug that caused
BlockDragStrategy.getInitialCandidate()to be called on every single drag step, including for mouse-driven drags. This method is intended to start keyboard drags at or close to an existing focused element on the workspace, and therefore only needs to be called fromstartDragfor keyboard moves. Instead, it was being called every timedrag()was called, regardless of the modality. This method is relatively expensive, and in any case this was just wasted effort.