docs: refactor toolbox codelab to use sample app#10115
Merged
zspriggs merged 16 commits intoJul 17, 2026
Merged
Conversation
gonfunko
reviewed
Jul 16, 2026
gonfunko
reviewed
Jul 17, 2026
Comment on lines
+15
to
+16
| import { CustomCategory, registerCustomCategory } from './custom_category.js'; | ||
| import { ToolboxLabel, registerToolboxLabel } from './toolbox_label.js'; |
Contributor
There was a problem hiding this comment.
The classes themselves don't seem to be used and could be removed in favor of just importing the registration functions
Contributor
Author
There was a problem hiding this comment.
Done, and adjusted in the .mdx files too
Comment on lines
+15
to
+16
| this.label.setAttribute('role', 'treeitem'); | ||
| this.label.setAttribute('aria-roledescription', 'label'); |
Contributor
There was a problem hiding this comment.
Optional, but might be worth using Blockly.utils.aria here
Contributor
Author
There was a problem hiding this comment.
Good call, done here and in the .mdx file
gonfunko
approved these changes
Jul 17, 2026
gonfunko
left a comment
gonfunko
left a comment
Contributor
There was a problem hiding this comment.
One minor nit but feel free to submit after, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Proposed Changes
Refactors the "Customizing a Blockly toolbox" codelab to use the sample app as starter code, rather than custom starter code. This is one of the more extensive refactors, because the original codelab used an XML toolbox, but the sample app uses a JSON toolbox, so the codelab had to be changed accordingly in a few different places.
There are also a few other changes in this refactor that were made for consistency and/or clarity:
Setupstep to newMake a Custom Categorystep. This makes this codelab more consistent with other codelabs, which have very minimalSetupsteps that don't include any coding.super()insetSelected()override and explained why. The old codelab set the ARIA state in the override without really explaining it, so I changed it to usesuperfor slightly better form and added an explanation.