Skip to content

npm run test:ghpages:beta doesn't work for hoisting #2397

Description

@maribethb

Check for duplicates

  • I have searched for similar issues before opening a new one.

Component

blockly-samples infrastructure

Description

We recently changed how we structure the dependencies in samples to use hoisting so we eliminate the "two blockly problem"

However running npm run test:ghpages:beta will try to install blockly@beta inside every plugin which is now wrong. That's fine for examples where we're not using hoisting. For samples it needs to install blockly@beta at the root of samples. but there might be problems if the plugins say they require a version of blockly that isn't compatible with the beta.

Don't run this command until this is fixed

Reproduction steps

Stack trace

No response

Screenshots

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Projects

    • Status
      Todo

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions