RibThreads: Add workaround for upstream bug with taper angle on two-sided pockets - #59
Merged
Merged
Conversation
FreeCAD 1.1 has a bug where the entrance taper direction depends on the direction of the pocket when a "Two sided" pocket is created. As a workaround, do not generate a "Two sided" pocket on affected FreeCAD versions, but instead generate two separate pockets, one for each direction. It is implemented using a feature-toggle, so we can revert back to the old generation code once this is fixed upstream. Link: FreeCAD/FreeCAD#32262
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FreeCAD 1.1 has a bug where the entrance taper direction depends on the direction of the pocket when a "Two sided" pocket is created (FreeCAD/FreeCAD#32262).
As a workaround, do not generate a "Two sided" pocket on affected FreeCAD versions, but instead generate two separate pockets, one for each direction.
It is implemented using a feature-toggle (
Utils.two_sided_taper_works()), so we can revert back to the old generation code once this is fixed upstream.Fixes #58.