Skip to content

[bsp/renesas][drivers] Fix SPI configuration faults - #11745

Open
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:fix/renesas-sci-spi-no-cs
Open

[bsp/renesas][drivers] Fix SPI configuration faults#11745
CYFS3 wants to merge 2 commits into
RT-Thread:masterfrom
CYFS3:fix/renesas-sci-spi-no-cs

Conversation

@CYFS3

@CYFS3 CYFS3 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

Renesas SPI 和 SCI SPI 驱动在配置软件片选时没有检查 RT_SPI_NO_CSPIN_NONE。无片选设备通过 rt_spi_bus_attach_device() 挂载后,无效引脚号会被 RA GPIO 驱动当作 PFS 索引使用,从而触发总线异常。

此外,SPI 驱动将 FSP 生成的 const 扩展配置强制转换为可写指针,并让波特率计算函数直接写入该配置。在 RA8P1 M85 上,该配置位于 Flash,写入时会触发 IMPRECISERR。SPI 控制器已经打开后也无法直接应用下一档时钟配置,导致时钟矩阵测试不能连续运行。

你的解决方案是什么 (what is your solution)

分别修改 bsp/renesas/libraries/HAL_Drivers/drivers/drv_sci.cdrv_spi.c

  • 当配置为 RT_SPI_NO_CScs_pin == PIN_NONE 时跳过 CS 引脚写操作;
  • 对有效 CS,根据 RT_SPI_CS_HIGH 设置正确的空闲电平;
  • 为每个 SPI 总线保存可写的 FSP 基础配置和扩展配置副本,在副本中计算运行时波特率,避免修改 Flash 中的生成配置;
  • SPI 配置变化且 FSP 实例已经打开时,关闭并使用新配置重新打开控制器。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/renesas/ra8d1-vision-board

    • 使用 sci2s,MOSI/MISO 回环,最大时钟 1 MHz,components.drivers.spi.loopback 测试通过。
  • BSP: bsp/renesas/ra8p1-titan-board/m85

    • 使用 spi0,MOSI/MISO 回环,时钟矩阵最大 10 MHz,components.drivers.spi.loopback 测试通过。
  • .config:

    • RA8D1: CONFIG_BSP_USING_SCI2=yCONFIG_BSP_USING_SCI2_SPI=yCONFIG_RT_UTEST_SPI_LOOPBACK=yCONFIG_RT_UTEST_SPI_LOOPBACK_BUS_NAME="sci2s"CONFIG_RT_UTEST_SPI_LOOPBACK_MAX_HZ=1000000
    • RA8P1 M85: CONFIG_BSP_USING_SPI0=yCONFIG_RT_UTEST_SPI_LOOPBACK=yCONFIG_RT_UTEST_SPI_LOOPBACK_BUS_NAME="spi0"CONFIG_RT_UTEST_SPI_LOOPBACK_MAX_HZ=10000000
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@CYFS3
CYFS3 requested review from Rbb666 and kurisaW as code owners August 24, 2026 10:00
@github-actions

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • Use workflow from 保持默认分支(通常为 master
    Keep the default branch (usually master) in Use workflow from
  • branch 输入框填写 PR 分支 fix/renesas-sci-spi-no-cs
    Enter PR branch fix/renesas-sci-spi-no-cs in the branch field
  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将作为独立提交推送至你的分支。
    The formatting changes will be pushed to your branch as a separate commit.

完成后,提交将自动更新至 fix/renesas-sci-spi-no-cs 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the fix/renesas-sci-spi-no-cs branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP BSP: Renesas BSP related with Renesas labels Aug 24, 2026
@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_renesas

Reviewers: @kurisaW

Changed Files (Click to expand)
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_sci.c
  • bsp/renesas/libraries/HAL_Drivers/drivers/drv_spi.c

📊 Current Review Status (Last Updated: 2026-08-24 18:18 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@CYFS3
CYFS3 marked this pull request as draft August 24, 2026 10:06
@CYFS3

CYFS3 commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

v5.3.0

@CYFS3
CYFS3 force-pushed the fix/renesas-sci-spi-no-cs branch from 3e60792 to 0ff6502 Compare August 24, 2026 10:18
@CYFS3
CYFS3 marked this pull request as ready for review August 24, 2026 10:18
@CYFS3 CYFS3 changed the title [bsp/renesas][drivers] Skip invalid chip select writes in SPI drivers [bsp/renesas][drivers] Fix SPI configuration faults Aug 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BSP: Renesas BSP related with Renesas BSP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant