Repository navigation
feat(interactive): support managed sessions on Windows #1953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2205b22
feat(interactive): support managed sessions on Windows
eitsupi dcc933b
docs(interactive): shorten the Windows notes in the architecture README
eitsupi fa90f26
docs(interactive): trim the Windows notes in the user guide
eitsupi e269790
ci: install arf with mise before Rtools on Windows
eitsupi 81dd769
ci: install arf before R on every OS
eitsupi ceea92d
test(interactive): resolve repository paths and skip fork-only checks…
eitsupi 0d59c88
fix(interactive): evaluate CRLF editor code on Windows
eitsupi 3a8c8a2
fix(interactive): start sessions without a workspace in the user home
eitsupi d376a80
test(interactive): accept language servers closing before the shutdow…
eitsupi b5dbdff
Merge remote-tracking branch 'upstream/main' into feat/interactive-wi…
eitsupi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Use the user's home for Windows sessions without a workspace
This newly enabled Windows path inherits
config.directoryfromInteractiveManager.create(), whose final fallback isprocess.env.HOME ?? process.cwd()(manager.ts:1110–1116). With no workspace open andHOMEunset, a Windows extension host started from the VS Code installation directory therefore starts arf/R there too. For example, withUSERPROFILE=C:\Users\exampleandcwd=C:\Program Files\Microsoft VS Code, I reproduced the compiled create method selecting the latter directory. In a system installation, ordinary relative writes such assaveRDS(x, "x.rds")then fail because that directory is not user-writable, and the session/export defaults point at the installation directory. The editor-test comment added in this PR also recognizes this possible Windows cwd. Please change the no-workspace fallback toos.homedir()and add a case withHOMEabsent, rather than relying on the extension host's cwd.