Skip to content

fix(protocol): reassemble blockwise OBSERVE notifications #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuiteYellow merged 2 commits into from
Aug 15, 2026
+892 −73
Merged

fix(protocol): reassemble blockwise OBSERVE notifications #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
231e88a
fix(protocol): reassemble blockwise OBSERVE notifications
QuiteYellow Aug 15, 2026
e63acb7
feat(protocol): surface OBSERVE refetch outcomes under DEBUG_BRIDGE
QuiteYellow Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions smartthings_local/protocol/coap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
URI_PATH = 11
URI_QUERY = 15
OBSERVE = 6
ETAG = 4
CONTENT_FORMAT = 12
ACCEPT = 17
BLOCK2 = 23
Expand Down Expand Up @@ -121,6 +122,14 @@ def block_value(num, more, szx):
return struct.pack('>I', v)[1:]


def block_fields(value):
"""Decode a CoAP Block-N option value. Inverse of block_value().
Returns (num, more, szx). An empty value means block 0, no more,
SZX=0 — RFC 7959 §2.2 allows a zero-length option to elide it."""
v = int.from_bytes(value, 'big')
return v >> 4, (v >> 3) & 1, v & 0x07


def fmt_code(c):
"""0x45 → '2.05', 0x84 → '4.04'. Used in log lines."""
return f"{c >> 5}.{c & 0x1F:02d}"
Expand Down
Loading