Repository navigation
feat(rust): apply staging in a transaction + e2e (#1889) - #1991
Merged
ZhuchkaTriplesix merged 1 commit intoNov 15, 2026
Merged
Conversation
Apply generated DML atomically; success clears the buffer, failure rolls back the DB and leaves staging intact. E2E covers update/insert/ delete, NULL set, empty plan, and constraint-failure rollback. Closes #1889
github-actions
Bot
added
data-grid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apply_plan_sqlite/apply_staging_sqliterun generated DML in one transactionrevert_all()on the buffer; failure → DB rolled back, staging untouchedTest plan
cargo test --locked staging(20 — includes 4 e2e)cargo clippy --locked -- -D warningsCloses #1889