Repository navigation
ci/run-integration.sh leaked every HTTP worker it booted - #11
Merged
Merged
Conversation
boot_http_worker recorded each server with BG_PIDS+=("$pid"), but every
caller used port="$(boot_http_worker ...)". A command substitution runs
in a subshell, so the append never reached the script's BG_PIDS and the
EXIT trap's cleanup killed nothing: each run left all of its `--http`
servers running. Harmless on a throwaway CI VM; on the shared build host
it accumulated batches of orphaned Java workers under PID 1.
boot_http_worker now sets BOOTED_PORT and is called directly, the
pattern vgi-python, vgi-go, vgi-rust and vgi-c++'s ci/run-integration.sh
already use. Checked by running the script's own boot_http_worker and
cleanup against a stub worker: 2 servers left behind before, 0 after,
with the ports still returned.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
boot_http_worker recorded each server with BG_PIDS+=("$pid"), but every
caller used port="$(boot_http_worker ...)". A command substitution runs
in a subshell, so the append never reached the script's BG_PIDS and the
EXIT trap's cleanup killed nothing: each run left all of its
--httpservers running. Harmless on a throwaway CI VM; on the shared build host
it accumulated batches of orphaned Java workers under PID 1.
boot_http_worker now sets BOOTED_PORT and is called directly, the
pattern vgi-python, vgi-go, vgi-rust and vgi-c++'s ci/run-integration.sh
already use. Checked by running the script's own boot_http_worker and
cleanup against a stub worker: 2 servers left behind before, 0 after,
with the ports still returned.
🤖 Generated with Claude Code