Repository navigation
fix(nevermore-cli): Per-endpoint rate limits, and test scripts return their results - #837
Merged
Merged
Conversation
…w waits in the spinner
Open Cloud meters each endpoint separately (Luau task creation is 5/min,
task polling 200/min), but the rate limiter kept a single remaining/reset
pair for every request. When task creation spent its quota, the next poll
waited out the full window even though polling had plenty left.
The limiter now keys quota state by method and endpoint path, and reports
every wait it takes. Cloud test and deploy runs show the wait as the
package's progress label ("Scheduling (rate limited 47s)"), so a
package sitting on "Scheduling" no longer looks hung. --verbose prints
each response's quota headers as [rate-limit] lines.
Deploy Results
1 package deployed, 1 passed, 0 failed in 3.7s · View logs Test Results
91 packages tested, 91 passed, 0 failed in 4m3s |
…act counts A single package run reads its counts from what the test script returns, but almost every test script discarded the guard's results, so single runs scraped counts out of Open Cloud's truncatable log text and warned about it on every run. Every package test script and the nevermore init templates now return the guard's results. The scraping fallback warning is also cut to one line; the log volume detail moves to --verbose.
Quenty
changed the title
The batch test runner script is now a set of BatchTestRunnerUtils helpers (isolate a package, reset its results mailbox, run its script, build its result) instead of one long loop. Behavior is unchanged: the same markers, failure text, and order of isolation, yields, and cleanup.
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud test and deploy runs no longer stall on unrelated requests when Roblox's Luau task-creation quota (5 per minute) runs out, because the Open Cloud rate limiter now tracks each endpoint's quota separately, and the spinner shows the wait ("Scheduling (rate limited 47s)") instead of looking hung. Every package test script and the
nevermore inittemplates now return the test runner's results, so a singlenevermore test --cloudreports exact counts instead of scraping them from truncatable logs. The scraping fallback warning is down to one line.