Skip to content

Change client secret header and return 401 on invalid jwt #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Swan merged 1 commit into from
Oct 4, 2026
Merged

Change client secret header and return 401 on invalid jwt #194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions middleware/authentication.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ type JWTClaims struct {

const (
messageNoHeader = "You must provide a valid `Authorization` or `auth` header."
messageNoAuthOrSecret = "You must provide a valid `Authorization`, `auth`, or `client_secret`."
messageNoAuthOrSecret = "You must provide a valid `Authorization`, `auth`, or `X-Client-Secret`."
)

// RequireAuth Middleware authentication function
Expand Down Expand Up @@ -129,7 +129,7 @@ func authenticateUser(c *gin.Context) (*db.User, *handlers.APIError) {

// authenticateApplicationClientSecret authenticates an active application client secret.
func authenticateApplicationClientSecret(c *gin.Context) (*db.Application, *handlers.APIError) {
secret := c.GetHeader("client_secret")
secret := c.GetHeader("X-Client-Secret")

if secret == "" {
return nil, &handlers.APIError{Status: http.StatusUnauthorized, Message: messageNoAuthOrSecret, Error: gorm.ErrRecordNotFound}
Expand Down Expand Up @@ -177,7 +177,8 @@ func authenticateJWT(header string) (*db.User, error) {
// Invalid or expired tokens must never continue to claim processing. In
// particular, parsing claims after a signature failure could allow a
// token signed with another secret to influence authentication.
if errors.Is(err, jwt.ErrSignatureInvalid) ||
if errors.Is(err, jwt.ErrTokenMalformed) ||
errors.Is(err, jwt.ErrSignatureInvalid) ||
errors.Is(err, jwt.ErrTokenSignatureInvalid) ||
errors.Is(err, jwt.ErrTokenExpired) {
return nil, nil
Expand Down
Loading