Skip to content

fix(security): resolve Codacy static analysis alerts in okf-ingest and catalog - #68

Merged
crapougnax merged 1 commit into
developfrom
fix/67-codacy-okf-ingest-security
Oct 13, 2026
Merged

crapougnax merged 1 commit into
developfrom
fix/67-codacy-okf-ingest-security

Conversation

@crapougnax

Copy link
Copy Markdown
Collaborator

Summary of Changes

Addresses the 24 Codacy static analysis issues identified in the ingestion pipeline:

  • Analysis Scope & False-Positives: Expanded .codacy.yml exclusions to include test suites across root exclude_paths and Semgrep engine configuration.
  • Path Traversal & FS Normalization: Added path.resolve path normalization and eslint-disable security/detect-non-literal-fs-filename annotations in dedup, monograph, writer, and catalog engine.
  • Async Error Handling: Handled exceptions with Log.warn structured logging in pdf.ts and modernized PDF pagerender callback to async/await with typed error capture.

Closes #67

…d catalog (#67)

- globalize test exclusions in .codacy.yml across all analysis engines
- handle async errors explicitly with Log.warn in pdf.ts
- annotate dynamic fs path serialization in dedup, monograph, writer, and engine
- enforce path.resolve normalization across all document exporters

Closes #67
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 146 complexity · 10 duplication

Metric Results
Complexity 146
Duplication 10

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@sonarqubecloud

Copy link
Copy Markdown

@crapougnax
crapougnax merged commit d1cf313 into develop Oct 13, 2026
4 checks passed
@crapougnax
crapougnax deleted the fix/67-codacy-okf-ingest-security branch October 13, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(security): resolve Codacy static analysis alerts in okf-ingest and catalog

1 participant