Repository navigation
Pass spaces to spacecheck_transform for TensorKit v0.17.3 - #89
Merged
Merged
Conversation
TensorKit v0.17.3 removed the method of `spacecheck_transform` that takes tensors, so permuting, transposing or braiding a block tensor threw a MethodError. The method that takes spaces exists in v0.17.2 as well. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TensorKit v0.17.3 removed the method of
spacecheck_transformthat accepts tensors and forwards their spaces (QuantumKitHub/TensorKit.jl#570). Thepermute!,transpose!andbraid!methods for block tensors still called it with tensors, so with TensorKit v0.17.3 every permute, transpose or braid of aBlockTensorMaporSparseBlockTensorMapthrows aMethodError. This currently breaks MPSKit's GPU CI.They now pass
space(tdst)andspace(tsrc). That method exists in v0.17.2 too, so the compat bound stays as it is. Locally the full test suite passes against TensorKit v0.17.3, and without this changepermuteandtransposeof dense and sparse block tensors throw that error on the CPU as well.🤖 Generated with Claude Code