Skip to content

Rebuild Vaultify into a fully functional encrypted vault app - #2

Merged
QuantumCoderrr merged 1 commit into
mainfrom
claude/modest-rubin-97pqpd
Nov 4, 2026
Merged

QuantumCoderrr merged 1 commit into
mainfrom
claude/modest-rubin-97pqpd

Conversation

@QuantumCoderrr

Copy link
Copy Markdown
Owner

Fixes:

  • API listed every user's items (queryset was not scoped to the owner)
  • Serializer exposed/accepted the user field and stored "encrypted" data in plaintext
  • Encryption helpers were never used; no migrations; hard-coded Postgres creds and secret key
  • package.json referenced a React frontend that does not exist (removed)

New:

  • Fernet/MultiFernet field encryption with key rotation
  • Server-rendered UI: landing, auth, dashboard with search/filters/tags, item CRUD with on-demand reveal/copy, password generator, security health, activity log, account management and JSON export
  • Brute-force login lockout, auto-locking sessions, audit logging
  • REST API with JWT auth, reveal/health actions and generator tools
  • Env-based settings (SQLite default, DATABASE_URL for Postgres), WhiteNoise
  • seed_demo command, 33 tests, CI workflow, Dockerfile, updated README

Fixes:
- API listed every user's items (queryset was not scoped to the owner)
- Serializer exposed/accepted the `user` field and stored "encrypted" data in plaintext
- Encryption helpers were never used; no migrations; hard-coded Postgres creds and secret key
- package.json referenced a React frontend that does not exist (removed)

New:
- Fernet/MultiFernet field encryption with key rotation
- Server-rendered UI: landing, auth, dashboard with search/filters/tags,
  item CRUD with on-demand reveal/copy, password generator, security health,
  activity log, account management and JSON export
- Brute-force login lockout, auto-locking sessions, audit logging
- REST API with JWT auth, reveal/health actions and generator tools
- Env-based settings (SQLite default, DATABASE_URL for Postgres), WhiteNoise
- seed_demo command, 33 tests, CI workflow, Dockerfile, updated README
@gitguardian

gitguardian Bot commented Nov 4, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
39583741 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
39583742 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
39583741 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
39583743 Triggered Generic High Entropy Secret ed22d24 backend/vault/management/commands/seed_demo.py View secret
39583742 Triggered Generic Password ed22d24 backend/vault/tests/test_api.py View secret
39583742 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
39583741 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
39583741 Triggered Generic Password ed22d24 backend/vault/tests/test_views.py View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@QuantumCoderrr
QuantumCoderrr merged commit fdf0736 into main Nov 4, 2026
6 of 7 checks passed
@QuantumCoderrr
QuantumCoderrr deleted the claude/modest-rubin-97pqpd branch November 4, 2026 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant