test(soroban): add unit tests for looping + rewards and cargo test CI gate - #433
Open
northersubair wants to merge 4 commits into
Open
test(soroban): add unit tests for looping + rewards and cargo test CI gate#433northersubair wants to merge 4 commits into
northersubair wants to merge 4 commits into
Conversation
… gate - 8 tests for looping contract (open_position ID monotonicity, validation) - 6 tests for rewards contract (accrue/claim accounting, edge cases) - Added cargo test job to soroban.yml CI workflow - Total: 28 tests passing across all contracts Closes Quantarq#420
YaronZaki
requested changes
Aug 20, 2026
YaronZaki
left a comment
YaronZaki
left a comment
Contributor
There was a problem hiding this comment.
@northersubair resolve conflicts please
…e-ci-gate # Conflicts: # quantara/soroban/contracts/Cargo.lock # quantara/soroban/contracts/rewards/Cargo.toml # quantara/soroban/contracts/rewards/src/lib.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add comprehensive unit tests for the looping and rewards Soroban contracts, and wire
cargo testinto the Soroban CI workflow so regressions are caught on every PR.Related Issue
Closes #420
Change Type
Testing Done
cargo testjob added to soroban.yml CI workflow (needs: [fmt, clippy])Screenshots (if UI changes)
None
Environment Variables
None
Checklist
make lintpasses (pylint on changed.pyfiles)make testpasses (pytest inquantara/web_app/tests/)Closes #420)