fix(pause): make protocol pause Redis-backed and constant-time - #431
Open
tolulopedd26 wants to merge 2 commits into
Open
fix(pause): make protocol pause Redis-backed and constant-time#431tolulopedd26 wants to merge 2 commits into
tolulopedd26 wants to merge 2 commits into
Conversation
- PauseController now uses redis.asyncio for cross-worker state - Pause survives worker restarts (Redis key protocol:paused) - Fail-closed: defaults to paused on Redis outage for safety - 5s in-memory cache to avoid Redis round-trip on every request - verify_admin_token uses hmac.compare_digest for constant-time comparison - Router endpoints use APIError envelope - 23 tests covering Redis state, cache, fail-closed, exempt paths Closes Quantarq#416
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bandit found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
|
||
| from __future__ import annotations | ||
|
|
||
| import asyncio |
| from web_app.api.main import app | ||
| from web_app.api.pausable import pause_controller | ||
| from web_app.db.database import get_database | ||
| import asyncio |
…s fail-closed 503s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replace the in-process PauseController with a Redis-backed implementation that propagates pause state to all workers and survives restarts. Fix admin token comparison to use constant-time hmac.compare_digest.
Related Issue
Closes #416
Change Type
Testing Done
protocol:pausedScreenshots (if UI changes)
None
Environment Variables
None (uses existing REDIS_URL)
Checklist
make lintpasses (pylint on changed.pyfiles)make testpasses (pytest inquantara/web_app/tests/)Closes #416)