Repository navigation
fix: validate benchmark observations and document composition candidate - #75
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
benchmark_price_invalidreason when any price in its consumed trailing lookback is nonfinite or nonpositive. Invalid prices are not dropped or backfilled; values outside the cutoff/lookback are not consumed.DESIGN_ONLY_NOT_RUNTIME, depends on a separate strong no-add/release contract, and does not implement or enable a new arbiter.Scope and compatibility
No thresholds, risk scalars, arbitration priorities, dependency pins, schema changes, runtime wiring, order permissions, or live activation. Existing missing-history reason codes and validation precedence are preserved.
as_of=Noneretains the latest matrix date as the requested cutoff, while the guard's emitted observation date is benchmark-specific. Duplicate-date normalization remains unchanged and is a separate policy ambiguity.The current selected UES consumer already prevalidates QQQ; this helper defect is not evidence of a live consumer failure.
Validation
direct_url.jsonlacksvcs_info) also reproduced on untouched mainLocal checks disabled socket connections and made no provider, AI, real-data, broker, or order calls. The exact declared AI dependency provenance and
python -m buildfrontend still require the repository's clean CI environment. This remains a draft for review.