Repository navigation
feat(console): expose specific account-facts binding reason - #991
Merged
Merged
Conversation
binding_status collapsed "no binding", "duplicate source", and "binding no longer matches the configured account identity" into the same missing state, so operators could not tell a broken rotation from an unconfigured account. Add binding_reason (bound/unbound/duplicate_source/identity_mismatch) to current and history read models while keeping binding_status unchanged for existing consumers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binding_reason(bound/unbound/duplicate_source/identity_mismatch) to the current and history account-facts read models.binding_statusunchanged (identity_mismatchstill maps tomissing) so existing UI gates and consumers are unaffected.accountFactsDetailprefersbinding_reasonwhen present; message text is unchanged and already localized.Motivation:
binding_statusmerged "never bound", "duplicate source", and "binding no longer matches configured identity" into one state, so operators could not distinguish a broken rotation from an unconfigured account (see the 2026-10-30 IBKR binding incident).Test plan
node tests/account_facts_validation.mjsnode tests/longbridge_financing_validation.mjsnode tests/overview_account_metadata_validation.mjsnode tests/console_account_facts_ui_validation.mjsand adjacent presentation validationsnpx tsc --noEmit(frontend)