Repository navigation
fix: refresh history after account bindings reload - #985
Merged
Merged
Conversation
Co-Authored-By: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing health history starts its first date using the previous ready account/binding state, then starts it again after those inputs reload. Production observation captured 154 GETs instead of 144 for ten accounts; an isolated real-browser fixture reproduced 15 history reads instead of 14 for one synthetic account.
Keep the grid's account and binding reads in a local section keyed by the refresh epoch, so each refresh begins in loading state. Preserve the existing summary, credential, empty/error/retry and cell cancellation behavior without changing the global request hook or any API.
Validation: type check/build/bundle budget, generated asset validation and the seven health/legacy-receipt UI regressions passed. Real React browser fixtures verified exactly 14 unique history reads per refresh; account and binding failures issue no old-grid reads, and both independent retry paths recover with 14 unique reads. No test dependencies were added. Independent review found no blocking issue and CI passed.
Released through #986. The final production build was exercised on all six pages in Chinese and English at 360x844, 390x844, 430x844 and 1440x900. Production health refresh now makes exactly 144 GETs, all 200, with zero duplicate URLs or load failures in the untruncated capture. Physical-device and upstream-data completeness are separate acceptance items.